feat: ui.checkbox_group#813
Merged
AkshatJawne merged 25 commits intodeephaven:mainfrom Oct 15, 2024
Merged
Conversation
Member
|
Can include docs with this as well #721 |
bmingles
reviewed
Sep 9, 2024
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
AkshatJawne
commented
Sep 16, 2024
Contributor
Author
AkshatJawne
left a comment
AkshatJawne
left a comment
There was a problem hiding this comment.
Ready for re-review @margaretkennedy
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
AkshatJawne
commented
Sep 18, 2024
Contributor
Author
AkshatJawne
left a comment
AkshatJawne
left a comment
There was a problem hiding this comment.
Ready for re-review @margaretkennedy
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
margaretkennedy
previously approved these changes
Sep 18, 2024
dsmmcken
requested changes
Sep 20, 2024
AkshatJawne
added a commit
to deephaven/web-client-ui
that referenced
this pull request
Sep 25, 2024
Resolves #2211 Needed for changes in plugins PR: deephaven/deephaven-plugins#813
Member
@dsmmcken the web-client-ui changes have merged, you'll still need to run web-client-ui locally though to test this change (since deephaven-core hasn't had a release with the new web-client-ui). |
Member
|
@AkshatJawne can you merge the latest |
mofojed
requested changes
Sep 27, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Code looks fine, examples need to ensure they run correctly. I checked a few of them and there were a couple issues.
Contributor
|
LGTM - I'm not on my "real" computer and don't have the Approve button
handy.
…On Wed, Oct 2, 2024 at 5:17 PM Akshat Jawne ***@***.***> wrote:
@AkshatJawne <https://github.com/AkshatJawne> requested your review on:
#813 <#813> feat:
ui.checkbox_group.
—
Reply to this email directly, view it on GitHub
<#813 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATR7UJIG2673VG2SFSI24MTZZRPFVAVCNFSM6AAAAABN4F2MUCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ4TKNBVGQYTQOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Margaret Kennedy
Deephaven Data Labs
|
margaretkennedy
approved these changes
Oct 15, 2024
dsmmcken
approved these changes
Oct 15, 2024
mofojed
pushed a commit
to mofojed/web-client-ui
that referenced
this pull request
Jan 7, 2025
Resolves deephaven#2211 Needed for changes in plugins PR: deephaven/deephaven-plugins#813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620 and Closes #721
Assuming changes made in this PR: deephaven/web-client-ui#2212