Skip to content

Commit 322f6ff

Browse files
authored
fix: Plugin peer dependencies do not get versions from lerna (#1517)
Apparently lerna doesn't treat `file` items in peer dependencies the same as it does for regular or dev dependencies. They don't get replaced and make the peer dependency unfindable. Compare these 2. In peer dependencies for plugin it lists `file:../dashboard` instead of an actual version. But for regular dependencies in components, they get a version. https://unpkg.com/@deephaven/plugin@0.48.0/package.json https://unpkg.com/@deephaven/components@0.48.0/package.json
1 parent a1de0f6 commit 322f6ff

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

package-lock.json

Lines changed: 9 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/plugin/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"build": "cross-env NODE_ENV=production run-p build:*",
2222
"build:babel": "babel ./src --out-dir ./dist --extensions \".ts,.tsx,.js,.jsx\" --source-maps --root-mode upward"
2323
},
24-
"peerDependencies": {
24+
"dependencies": {
2525
"@deephaven/components": "file:../components",
2626
"@deephaven/iris-grid": "file:../iris-grid",
2727
"@deephaven/jsapi-types": "file:../jsapi-types"

0 commit comments

Comments
 (0)