fix: Plugin peer dependencies do not get versions from lerna#1517
Merged
mofojed merged 1 commit intodeephaven:mainfrom Sep 15, 2023
Merged
fix: Plugin peer dependencies do not get versions from lerna#1517mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 46.42% 46.42%
=======================================
Files 558 558
Lines 35714 35714
Branches 8916 8916
=======================================
Hits 16582 16582
Misses 19082 19082
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently lerna doesn't treat
fileitems in peer dependencies the same as it does for regular or dev dependencies. They don't get replaced and make the peer dependency unfindable.Compare these 2. In peer dependencies for plugin it lists
file:../dashboardinstead of an actual version. But for regular dependencies in components, they get a version.https://unpkg.com/@deephaven/plugin@0.48.0/package.json
https://unpkg.com/@deephaven/components@0.48.0/package.json