Skip to content

Commit 419f95d

Browse files
authored
refactor: Change TabEvent to object literal, add TabEventMap (#2191)
Add TabEventMap assiciating TabEvent types to callback signatures. Change TabEvent to object literal so it could be used to define TabEventMap. BREAKING CHANGE: Delete unused event types: `openPQObject`, `openControl`, `reload`, `clearAllFilters`.
1 parent f5b01fd commit 419f95d

2 files changed

Lines changed: 16 additions & 13 deletions

File tree

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
1-
class TabEvent {
2-
static focus = 'TabEvent.focus';
3-
4-
static blur = 'TabEvent.blur';
5-
6-
static openPQObject = 'TabEvent.openPQObject';
7-
8-
static openControl = 'TabEvent.openControl';
9-
10-
static reload = 'TabEvent.reload';
11-
12-
static clearAllFilters = 'TabEvent.clearAllFilters';
13-
}
1+
const TabEvent = Object.freeze({
2+
focus: 'TabEvent.focus',
3+
blur: 'TabEvent.blur',
4+
});
145

156
export default TabEvent;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { ValueOf } from '@deephaven/utils';
2+
import TabEvent from './TabEvent';
3+
4+
export type TabEventType = ValueOf<typeof TabEvent>;
5+
6+
export interface TabEventMap
7+
extends Record<TabEventType, (...args: never[]) => void> {
8+
[TabEvent.focus]: () => void;
9+
[TabEvent.blur]: () => void;
10+
}
11+
12+
export default TabEventMap;

0 commit comments

Comments
 (0)