refactor: Change TabEvent to object literal, add TabEventMap#2191
Merged
vbabich merged 2 commits intodeephaven:mainfrom Aug 20, 2024
Merged
refactor: Change TabEvent to object literal, add TabEventMap#2191vbabich merged 2 commits intodeephaven:mainfrom
vbabich merged 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 46.66% 46.64% -0.03%
==========================================
Files 692 692
Lines 38629 38578 -51
Branches 9814 9821 +7
==========================================
- Hits 18028 17995 -33
- Misses 20548 20572 +24
+ Partials 53 11 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
changed the title
mofojed
requested changes
Aug 20, 2024
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TabEventMap associating TabEvent types to callback signatures.
Change TabEvent to object literal so it could be used to define TabEventMap.
BREAKING CHANGE: Delete unused event types:
openPQObject,openControl,reload,clearAllFilters.