Skip to content

Commit 5a8f34d

Browse files
authored
fix: tree and rollup default to non-sortable (#1404)
Closes #1402
1 parent ba13c91 commit 5a8f34d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/iris-grid/src/IrisGridTableModel.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,6 @@ class IrisGridTableModel extends IrisGridTableModelTemplate<Table, UIRow> {
269269
return this.frozenColumns.includes(this.columns[modelIndex].name);
270270
}
271271

272-
isColumnSortable(modelIndex: ModelIndex): boolean {
273-
return this.columns[modelIndex].isSortable ?? true;
274-
}
275-
276272
async delete(ranges: GridRange[]): Promise<void> {
277273
if (!this.isDeletableRanges(ranges)) {
278274
throw new Error(`Undeletable ranges ${ranges}`);

packages/iris-grid/src/IrisGridTableModelTemplate.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1581,6 +1581,10 @@ class IrisGridTableModelTemplate<
15811581
return !this.isKeyColumn(modelIndex);
15821582
}
15831583

1584+
isColumnSortable(modelIndex: ModelIndex): boolean {
1585+
return this.columns[modelIndex].isSortable ?? true;
1586+
}
1587+
15841588
isKeyColumn(x: ModelIndex): boolean {
15851589
return x < (this.inputTable?.keyColumns.length ?? 0);
15861590
}

0 commit comments

Comments
 (0)