Description
After #1390 tree and rollup tables are not sortable.
The definition added to IrisGridTableModel should be in IrisGridTableModelTemplate because IrisGridTreeTableModel is using the default implementation which just always returns false.
We should also change the default to true probably since the engine should just fail the sort and tell the UI in those cases. According to this comment, the bug where the error was thrown instead of reported as a message to the UI is fixed, so should be fine to default to let the user try to sort (although the default implementation in IrisGridModel won't be hit in our uses)
Steps to reproduce
- Create a tree or rollup table.
- Try to sort a column that you would normally be able to sort
Expected results
- Column sorts
Actual results
- Column is not sortable in the UI
Versions
- Engine Version: 0.26.0
- Web UI Version: 0.44.0
Description
After #1390 tree and rollup tables are not sortable.
The definition added to
IrisGridTableModelshould be inIrisGridTableModelTemplatebecauseIrisGridTreeTableModelis using the default implementation which just always returns false.We should also change the default to true probably since the engine should just fail the sort and tell the UI in those cases. According to this comment, the bug where the error was thrown instead of reported as a message to the UI is fixed, so should be fine to default to let the user try to sort (although the default implementation in
IrisGridModelwon't be hit in our uses)Steps to reproduce
Expected results
Actual results
Versions