fix: Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list (#1596)

Fixes #1593

I don't think these breaking changes should affect enterprise since it
doesn't use `@deephaven/app-utils`

BREAKING CHANGE:
- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.

Author: mattrunyon

package-lock.json

@@ -8,7 +8,7 @@ import {
 import { LoadingOverlay } from '@deephaven/components';
 import { useClient } from '@deephaven/jsapi-bootstrap';
 import { getErrorMessage } from '@deephaven/utils';
-import { PluginsContext } from './PluginsBootstrap';
+import { PluginsContext } from '@deephaven/plugin';
 import { getAuthPluginComponent } from '../plugins';
 import LoginNotifier from './LoginNotifier';
 

packages/app-utils/src/components/AuthBootstrap.tsx

@@ -1,12 +1,11 @@
-import React, { createContext, useEffect, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 import { LoadingOverlay } from '@deephaven/components';
 import { useApi, useClient } from '@deephaven/jsapi-bootstrap';
 import type { IdeConnection } from '@deephaven/jsapi-types';
+import { ConnectionContext } from '@deephaven/jsapi-components';
 import Log from '@deephaven/log';
 
-const log = Log.module('@deephaven/jsapi-components.ConnectionBootstrap');
-
-export const ConnectionContext = createContext<IdeConnection | null>(null);
+const log = Log.module('@deephaven/app-utils.ConnectionBootstrap');
 
 export type ConnectionBootstrapProps = {
   /**

packages/app-utils/src/components/ConnectionBootstrap.tsx

@@ -1,8 +1,10 @@
-import { type Plugin } from '@deephaven/plugin';
-import React, { createContext, useEffect, useState } from 'react';
-import { PluginModuleMap, loadModulePlugins } from '../plugins';
-
-export const PluginsContext = createContext<PluginModuleMap | null>(null);
+import React, { useEffect, useState } from 'react';
+import {
+  type Plugin,
+  type PluginModuleMap,
+  PluginsContext,
+} from '@deephaven/plugin';
+import { loadModulePlugins } from '../plugins';
 
 export type PluginsBootstrapProps = {
   /**

packages/app-utils/src/components/PluginsBootstrap.tsx

@@ -1,7 +1,7 @@
-import { ThemeProvider } from '@deephaven/components';
 import { useContext, useMemo } from 'react';
+import { ThemeProvider } from '@deephaven/components';
+import { PluginsContext } from '@deephaven/plugin';
 import { getThemeDataFromPlugins } from '../plugins';
-import { PluginsContext } from './PluginsBootstrap';
 
 export interface ThemeBootstrapProps {
   children: React.ReactNode;

packages/app-utils/src/components/ThemeBootstrap.tsx

@@ -5,8 +5,5 @@ export * from './FontBootstrap';
 export * from './FontsLoaded';
 export * from './PluginsBootstrap';
 export * from './ThemeBootstrap';
-export * from './usePlugins';
-export * from './useConnection';
 export * from './useServerConfig';
 export * from './useUser';
-export * from './useLoadTablePlugin';

packages/app-utils/src/components/index.ts

@@ -1,7 +1,7 @@
 import { getThemeKey, ThemeData } from '@deephaven/components';
 import Log from '@deephaven/log';
 import {
-  type PluginModule,
+  type PluginModuleMap,
   type AuthPlugin,
   type AuthPluginComponent,
   isAuthPlugin,
@@ -18,8 +18,6 @@ import loadRemoteModule from './loadRemoteModule';
 
 const log = Log.module('@deephaven/app-utils.PluginUtils');
 
-export type PluginModuleMap = Map<string, PluginModule>;
-
 export type PluginManifestPluginInfo = {
   name: string;
   main: string;

packages/app-utils/src/plugins/PluginUtils.tsx

@@ -18,6 +18,7 @@ import {
 import { FileStorage } from '@deephaven/file-explorer';
 import { useApi, useClient } from '@deephaven/jsapi-bootstrap';
 import type { dh as DhType, IdeConnection } from '@deephaven/jsapi-types';
+import { useConnection } from '@deephaven/jsapi-components';
 import {
   DecimalColumnFormatter,
   getSessionDetails,
@@ -44,14 +45,9 @@ import {
   Workspace,
   WorkspaceStorage,
   ServerConfigValues,
-  DeephavenPluginModuleMap,
 } from '@deephaven/redux';
-import {
-  useConnection,
-  usePlugins,
-  useServerConfig,
-  useUser,
-} from '@deephaven/app-utils';
+import { useServerConfig, useUser } from '@deephaven/app-utils';
+import { type PluginModuleMap, usePlugins } from '@deephaven/plugin';
 import { setLayoutStorage as setLayoutStorageAction } from '../redux/actions';
 import App from './App';
 import LocalWorkspaceStorage from '../storage/LocalWorkspaceStorage';
@@ -76,7 +72,7 @@ interface AppInitProps {
   setLayoutStorage: (layoutStorage: LayoutStorage) => void;
   setDashboardConnection: (id: string, connection: IdeConnection) => void;
   setDashboardSessionWrapper: (id: string, wrapper: SessionWrapper) => void;
-  setPlugins: (map: DeephavenPluginModuleMap) => void;
+  setPlugins: (map: PluginModuleMap) => void;
   setUser: (user: User) => void;
   setWorkspace: (workspace: Workspace) => void;
   setWorkspaceStorage: (workspaceStorage: WorkspaceStorage) => void;

packages/code-studio/src/main/AppInit.tsx

@@ -76,7 +76,6 @@ import {
   RootState,
   User,
   ServerConfigValues,
-  DeephavenPluginModuleMap,
 } from '@deephaven/redux';
 import { bindAllMethods, PromiseUtils } from '@deephaven/utils';
 import GoldenLayout from '@deephaven/golden-layout';
@@ -86,6 +85,7 @@ import {
   isDashboardPlugin,
   type LegacyDashboardPlugin,
   isLegacyDashboardPlugin,
+  type PluginModuleMap,
 } from '@deephaven/plugin';
 import JSZip from 'jszip';
 import SettingsMenu from '../settings/SettingsMenu';
@@ -131,7 +131,7 @@ interface AppMainContainerProps {
   updateWorkspaceData: (workspaceData: Partial<WorkspaceData>) => void;
   user: User;
   workspace: Workspace;
-  plugins: DeephavenPluginModuleMap;
+  plugins: PluginModuleMap;
   serverConfigValues: ServerConfigValues;
 }
 
@@ -689,7 +689,7 @@ export class AppMainContainer extends Component<
     });
   }
 
-  getDashboardPlugins = memoize((plugins: DeephavenPluginModuleMap) => {
+  getDashboardPlugins = memoize((plugins: PluginModuleMap) => {
     const dashboardPlugins = [...plugins.entries()].filter(
       ([, plugin]) =>
         isDashboardPlugin(plugin) || isLegacyDashboardPlugin(plugin)

packages/code-studio/src/main/AppMainContainer.tsx

@@ -22,7 +22,6 @@
     "build:sass": "sass --embed-sources --load-path=../../node_modules ./src:./dist"
   },
   "dependencies": {
-    "@deephaven/app-utils": "file:../app-utils",
     "@deephaven/chart": "file:../chart",
     "@deephaven/components": "file:../components",
     "@deephaven/console": "file:../console",
@@ -34,6 +33,7 @@
     "@deephaven/icons": "file:../icons",
     "@deephaven/iris-grid": "file:../iris-grid",
     "@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
+    "@deephaven/jsapi-components": "file:../jsapi-components",
     "@deephaven/jsapi-types": "file:../jsapi-types",
     "@deephaven/jsapi-utils": "file:../jsapi-utils",
     "@deephaven/log": "file:../log",