fix: Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list#1596
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Oct 24, 2023
Merged
Conversation
…ns dependency list
bmingles
reviewed
Oct 24, 2023
mofojed
requested changes
Oct 24, 2023
bmingles
reviewed
Oct 24, 2023
mofojed
approved these changes
Oct 24, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
+ Coverage 46.65% 46.74% +0.09%
==========================================
Files 575 583 +8
Lines 36189 36256 +67
Branches 9063 9072 +9
==========================================
+ Hits 16883 16947 +64
- Misses 19254 19257 +3
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1593
I don't think these breaking changes should affect enterprise since it doesn't use
@deephaven/app-utilsBREAKING CHANGE:
usePluginsandPluginsContextwere moved from@deephaven/app-utilsto@deephaven/plugin.useLoadTablePluginwas moved from@deephaven/app-utilsto@deephaven/dashboard-core-plugins.useConnectionandConnectionContextwere moved from@deephaven/app-utilsto@deephaven/jsapi-components.DeephavenPluginModuleMapwas removed from@deephaven/redux. UsePluginModuleMapfrom@deephaven/plugininstead.