Skip to content

fix: Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list#1596

Merged
mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon:mattrunyon-1593
Oct 24, 2023
Merged

fix: Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list#1596
mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon:mattrunyon-1593

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

@mattrunyon mattrunyon commented Oct 23, 2023

Fixes #1593

I don't think these breaking changes should affect enterprise since it doesn't use @deephaven/app-utils

BREAKING CHANGE:

  • usePlugins and PluginsContext were moved from @deephaven/app-utils to @deephaven/plugin.
  • useLoadTablePlugin was moved from @deephaven/app-utils to @deephaven/dashboard-core-plugins.
  • useConnection and ConnectionContext were moved from @deephaven/app-utils to @deephaven/jsapi-components.
  • DeephavenPluginModuleMap was removed from @deephaven/redux. Use PluginModuleMap from @deephaven/plugin instead.

@mattrunyon mattrunyon self-assigned this Oct 23, 2023
Comment thread packages/app-utils/tsconfig.json Outdated
Comment thread packages/app-utils/tsconfig.json Outdated
Comment thread packages/redux/src/actions.ts
@bmingles bmingles self-requested a review October 24, 2023 14:07
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon enabled auto-merge (squash) October 24, 2023 19:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c736708) 46.65% compared to head (6f1b474) 46.74%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
+ Coverage   46.65%   46.74%   +0.09%     
==========================================
  Files         575      583       +8     
  Lines       36189    36256      +67     
  Branches     9063     9072       +9     
==========================================
+ Hits        16883    16947      +64     
- Misses      19254    19257       +3     
  Partials       52       52              
Flag Coverage Δ
unit 46.74% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/app-utils/src/components/AuthBootstrap.tsx 93.33% <ø> (ø)
...s/app-utils/src/components/ConnectionBootstrap.tsx 76.47% <100.00%> (-0.68%) ⬇️
...ages/app-utils/src/components/PluginsBootstrap.tsx 93.75% <ø> (-0.37%) ⬇️
...ckages/app-utils/src/components/ThemeBootstrap.tsx 100.00% <ø> (ø)
packages/app-utils/src/plugins/PluginUtils.tsx 40.00% <ø> (ø)
packages/code-studio/src/main/AppInit.tsx 0.00% <ø> (ø)
packages/code-studio/src/main/AppMainContainer.tsx 31.15% <100.00%> (ø)
...ackages/dashboard-core-plugins/src/ChartPlugin.tsx 15.90% <ø> (ø)
.../dashboard-core-plugins/src/WidgetLoaderPlugin.tsx 100.00% <ø> (ø)
...dashboard-core-plugins/src/panels/ConsolePanel.tsx 44.23% <ø> (ø)
... and 6 more

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit 7b59763 into deephaven:main Oct 24, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 24, 2023
@mattrunyon mattrunyon deleted the mattrunyon-1593 branch June 23, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependencies

3 participants