Skip to content

Commit aee4047

Browse files
authored
refactor: Switch to generated jsapi types (#1842)
Fixes #1770
1 parent fe6c779 commit aee4047

210 files changed

Lines changed: 1416 additions & 3102 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

jest.config.base.cjs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,11 @@ module.exports = {
6363
),
6464
// Handle monaco worker files
6565
'\\.worker.*$': 'identity-obj-proxy',
66-
// All packages except icons use src code
67-
'^@deephaven/(?!icons)(.*)$': path.join(__dirname, './packages/$1/src'),
66+
// All packages except icons and jsapi-types use src code
67+
'^@deephaven/(?!icons|jsapi-types)(.*)$': path.join(
68+
__dirname,
69+
'./packages/$1/src'
70+
),
6871
},
6972
testEnvironment: 'jsdom',
7073
setupFilesAfterEnv: [path.join(__dirname, './jest.setup.ts')],

package-lock.json

Lines changed: 39 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
"@deephaven/jsapi-bootstrap": "file:packages/jsapi-bootstrap",
175175
"@deephaven/jsapi-components": "file:packages/jsapi-components",
176176
"@deephaven/jsapi-shim": "file:packages/jsapi-shim",
177-
"@deephaven/jsapi-types": "file:packages/jsapi-types",
177+
"@deephaven/jsapi-types": "1.0.0-dev0.33.1",
178178
"@deephaven/jsapi-utils": "file:packages/jsapi-utils",
179179
"@deephaven/log": "file:packages/log",
180180
"@deephaven/mocks": "file:packages/mocks",

packages/app-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"@deephaven/iris-grid": "file:../iris-grid",
4040
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
4141
"@deephaven/jsapi-components": "file:../jsapi-components",
42-
"@deephaven/jsapi-types": "file:../jsapi-types",
42+
"@deephaven/jsapi-types": "1.0.0-dev0.33.1",
4343
"@deephaven/jsapi-utils": "file:../jsapi-utils",
4444
"@deephaven/log": "file:../log",
4545
"@deephaven/plugin": "file:../plugin",

packages/app-utils/src/components/AuthBootstrap.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ export function AuthBootstrap({ children }: AuthBootstrapProps): JSX.Element {
4848
let isCanceled = false;
4949
async function loadAuthConfigValues(): Promise<void> {
5050
try {
51-
const newAuthConfigValues = await client.getAuthConfigValues();
51+
const newAuthConfigValues = (await client.getAuthConfigValues()) as [
52+
string,
53+
string,
54+
][];
5255
if (!isCanceled) {
5356
setAuthConfig(new Map(newAuthConfigValues));
5457
}

packages/app-utils/src/components/ConnectionBootstrap.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
useApi,
77
useClient,
88
} from '@deephaven/jsapi-bootstrap';
9-
import type { IdeConnection, VariableDescriptor } from '@deephaven/jsapi-types';
9+
import type { dh } from '@deephaven/jsapi-types';
1010
import Log from '@deephaven/log';
1111
import { assertNotNull } from '@deephaven/utils';
1212
import ConnectionContext from './ConnectionContext';
@@ -30,7 +30,7 @@ export function ConnectionBootstrap({
3030
const api = useApi();
3131
const client = useClient();
3232
const [error, setError] = useState<unknown>();
33-
const [connection, setConnection] = useState<IdeConnection>();
33+
const [connection, setConnection] = useState<dh.IdeConnection>();
3434
useEffect(
3535
function initConnection() {
3636
let isCanceled = false;
@@ -76,7 +76,7 @@ export function ConnectionBootstrap({
7676
);
7777

7878
const objectFetcher = useCallback(
79-
async (descriptor: VariableDescriptor) => {
79+
async (descriptor: dh.ide.VariableDescriptor) => {
8080
assertNotNull(connection, 'No connection available to fetch object with');
8181
return connection.getObject(sanitizeVariableDescriptor(descriptor));
8282
},
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { createContext } from 'react';
2-
import type { IdeConnection } from '@deephaven/jsapi-types';
2+
import type { dh } from '@deephaven/jsapi-types';
33

4-
export const ConnectionContext = createContext<IdeConnection | null>(null);
4+
export const ConnectionContext = createContext<dh.IdeConnection | null>(null);
55

66
export default ConnectionContext;

packages/app-utils/src/components/ServerConfigBootstrap.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ export function ServerConfigBootstrap({
2929
let isCanceled = false;
3030
async function loadServerConfigValues(): Promise<void> {
3131
try {
32-
const newServerConfigValues = await client.getServerConfigValues();
32+
const newServerConfigValues =
33+
(await client.getServerConfigValues()) as [string, string][];
3334
if (!isCanceled) {
3435
setServerConfig(new Map(newServerConfigValues));
3536
}

0 commit comments

Comments
 (0)