fix: DH-14237: down arrow in console not returning to blank field#1082
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom Feb 9, 2023
Merged
fix: DH-14237: down arrow in console not returning to blank field#1082mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 41.86% 42.10% +0.24%
==========================================
Files 432 432
Lines 32555 32555
Branches 8191 8191
==========================================
+ Hits 13628 13707 +79
+ Misses 18874 18795 -79
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DH-14237
Was incorrectly converted in #646
Switched the arrow keys to use
codeinstead ofkeyCodebecause RTL user-event does not setkeyCodewhich is a deprecated property