Convert Console to typescript#646
Merged
Zhou-Ziheng merged 26 commits intodeephaven:mainfrom Jul 21, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #646 +/- ##
==========================================
- Coverage 35.76% 35.71% -0.05%
==========================================
Files 396 397 +1
Lines 29183 29333 +150
Branches 6957 7023 +66
==========================================
+ Hits 10436 10475 +39
- Misses 18561 18710 +149
+ Partials 186 148 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mofojed
requested changes
Jul 13, 2022
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
I'll have more comments after lunch, just posting my first part of the review.
mofojed
requested changes
Jul 13, 2022
mofojed
requested changes
Jul 19, 2022
mofojed
requested changes
Jul 20, 2022
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #641