fix: Fix the style guide#1119
Merged
mofojed merged 2 commits intodeephaven:mainfrom Mar 2, 2023
Merged
Conversation
Member
mofojed
commented
Mar 1, 2023
mofojed
commented
- Styleguide index wasn't updated to use JS API as a module correctly
- Styleguide index wasn't updated to use JS API as a module correctly
mattrunyon
previously approved these changes
Mar 1, 2023
- No props so these components shouldn't re-render - We want these effects to fire before we render any of the children
Codecov Report
@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 43.37% 43.37% -0.01%
==========================================
Files 434 435 +1
Lines 32617 32619 +2
Branches 8218 8218
==========================================
Hits 14148 14148
- Misses 18420 18422 +2
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattrunyon
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.