feat: DH-14581 Added isACLEditor prop to Redux state#1201
Merged
bmingles merged 1 commit intodeephaven:mainfrom Apr 4, 2023
Merged
feat: DH-14581 Added isACLEditor prop to Redux state#1201bmingles merged 1 commit intodeephaven:mainfrom
bmingles merged 1 commit intodeephaven:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 44.20% 44.20%
=======================================
Files 448 448
Lines 33437 33437
Branches 8404 8404
=======================================
Hits 14781 14781
Misses 18606 18606
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
approved these changes
Apr 4, 2023
Comment on lines
+17
to
19
| isACLEditor: boolean; | ||
| isSuperUser: boolean; | ||
| isQueryViewOnly: boolean; |
Member
There was a problem hiding this comment.
Side note - these permissions really only exist/matter for Enterprise users, so we should be extending the interface in Enterprise redux to add these permissions. That hasn't been converted to TS yet though, and it's not doing much harm being added here.
bmingles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports Enterprise DH-14581
resolves #1200