Skip to content

feat: DH-14581 Added isACLEditor prop to Redux state #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmingles merged 1 commit into from
Apr 4, 2023
Merged

feat: DH-14581 Added isACLEditor prop to Redux state #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/code-studio/src/main/AppInit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ function AppInit(props: AppInitProps) {
operateAs: name,
groups: [],
permissions: {
isACLEditor: false,
isSuperUser: false,
isQueryViewOnly: false,
isNonInteractive: false,
Expand Down
1 change: 1 addition & 0 deletions packages/redux/src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export interface DeephavenPluginModule {}
export type DeephavenPluginModuleMap = Map<string, DeephavenPluginModule>;

export interface UserPermissions {
isACLEditor: boolean;
isSuperUser: boolean;
isQueryViewOnly: boolean;
Comment on lines +17 to 19
Copy link
Copy Markdown
Member

@mofojed mofojed Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note - these permissions really only exist/matter for Enterprise users, so we should be extending the interface in Enterprise redux to add these permissions. That hasn't been converted to TS yet though, and it's not doing much harm being added here.

isNonInteractive: boolean;
Expand Down
⚡