feat: Table rendering support for databars#1212
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
- Coverage 45.57% 45.27% -0.31%
==========================================
Files 486 485 -1
Lines 34101 34167 +66
Branches 8538 8576 +38
==========================================
- Hits 15543 15470 -73
- Misses 18507 18646 +139
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
83234d6 to
c467052
Compare
| state: GridRenderState, | ||
| column: VisibleIndex, | ||
| row: VisibleIndex, | ||
| textOverride?: string |
There was a problem hiding this comment.
Not part of your change, but just something that bugs me - textOverride is a property that's really only relevant to the TextCellRenderer, not the general CellRenderer case. I feel like the text override (which is only really used in IrisGridRenderer to display null or empty in a specific case) should be pushed down into model.textForCell, and even have a model.fontForCell... there may have been other implications for why we didn't do that. @mattrunyon added it as part of PR #408 , but it doesn't look like I had any comments there about pushing textOverride down to the model and why we went with the direction we did.
mofojed
left a comment
There was a problem hiding this comment.
Looking great! As discussed, will not be merging until start of May.
…ndering-support-for-databars
Closes #1151
The example can be seen at the style guide.
IrisGridRendererandGridRenderernow use different cell renderers depending on the type.