feat: Improve plugin load error handling#1214
Merged
mattrunyon merged 9 commits intodeephaven:mainfrom Apr 14, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 44.20% 44.25% +0.04%
==========================================
Files 448 450 +2
Lines 33437 33488 +51
Branches 8404 8427 +23
==========================================
+ Hits 14781 14820 +39
- Misses 18606 18618 +12
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
requested changes
Apr 13, 2023
mofojed
requested changes
Apr 14, 2023
mofojed
requested changes
Apr 14, 2023
mofojed
requested changes
Apr 14, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Would recommend throwing an error instead of a string
mofojed
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads plugins individually instead of failing to register if any plugin fails to load. Previously if any plugin failed to load for any reason then no plugins were registered.
Does some validation on if the manifest file exists and the structure of it so that the errors are more descriptive. Does not throw a 2nd error about
Unexpected token <if there is no manifest file