fix: Move @deephaven/redux to be a dependency instead#1249
Merged
mofojed merged 1 commit intodeephaven:mainfrom Apr 25, 2023
Merged
fix: Move @deephaven/redux to be a dependency instead#1249mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- Issue when trying to do an `npm install` in another project that depended on @deephaven/dashboard, as the peerDependency would not resolve the "file:../redux" path - Not sure if lerna or npm should automatically be replacing those at publish time? - Was adding redux as a peerDep because we only want one instance of the redux store; otherwise weird bugs can occur that are difficult to track down - It was already the case with @deephaven/dashboard-core-plugins that it was just a dependency, not a peerDependency. Enterprise handled it just by doing deduplication - Just move @deephaven/redux to be a dependency instead of a peerDependency
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 473 473
Lines 33703 33703
Branches 8455 8455
=======================================
Hits 15394 15394
Misses 18258 18258
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
Published an alpha package, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installin another project that depended on @deephaven/dashboard, as the peerDependency would not resolve the "file:../redux" path