feat: Update @vscode/codicons to v0.0.33#1259
Merged
Conversation
They renamed circle-large-outline to circle-large for consistency. Update adds several new icons. I've fixed our usage to match for the renamed icon.
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 45.57% 45.57%
=======================================
Files 484 484
Lines 34077 34077
Branches 8532 8532
=======================================
Hits 15531 15531
Misses 18495 18495
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
May 2, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
We should still add Breaking Change to this PR, as we're no longer exporting vsCircleLargeOutline from @deephaven/icons
Contributor
Author
|
True. I just checked and enterprise does use vsCircleLargeOutline in QueryStatusIcon. |
Member
|
Another option would be to re-export it with the old name to reduce breakage? But may be more hassle than it's worth. |
Contributor
Author
|
better to let it break and update the other side I think, the name change makes sense. |
mofojed
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update adds several new icons see https://github.com/microsoft/vscode-codicons/releases/tag/0.0.33 for changes.
They renamed circle-large-outline to circle-large for naming consistency. I've fixed our usage of vsCircleLargeOutline to vsCircleLarge for the renamed icon (no change in visuals).
BREAKING CHANGE:
vsCircleLargeOutlineicon renamed tovsCircleLarge