feat: web-client-ui changes required for deephaven.ui#1567
Merged
mofojed merged 13 commits intodeephaven:mainfrom Oct 17, 2023
Merged
feat: web-client-ui changes required for deephaven.ui#1567mofojed merged 13 commits intodeephaven:mainfrom
mofojed merged 13 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 46.45% 46.44% -0.01%
==========================================
Files 572 572
Lines 36079 36081 +2
Branches 9034 9035 +1
==========================================
Hits 16759 16759
- Misses 19268 19270 +2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Oct 16, 2023
mattrunyon
reviewed
Oct 17, 2023
- Needed for chart plugins to work
- Now styles Spectrum components more or less correctly
- Instead of building apps in parallel build at the same time - Currently getting an OoM error when building in GitHub publish alpha action
- It was only in code-studio and embed-grid for some reason
- Brian will be implementing this with his changes
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
- Will also have a follow up ticket to use the automatically generated types
mofojed
force-pushed
the
ui-plugin-prototype-no-spectrum
branch
from
e22621e to
092a831
Compare
mattrunyon
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote-component.config.ts