feat: Theming - Charts#1608
Merged
bmingles merged 16 commits intodeephaven:mainfrom Nov 7, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
=======================================
Coverage 46.71% 46.71%
=======================================
Files 583 586 +3
Lines 36308 36340 +32
Branches 9094 9095 +1
=======================================
+ Hits 16961 16977 +16
- Misses 19295 19311 +16
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bmingles
force-pushed
the
1572-theming-charts
branch
2 times, most recently
from
289bc10 to
144d2fe
Compare
bmingles
force-pushed
the
1572-theming-charts
branch
from
ee3eb43 to
d7b4adc
Compare
bmingles
force-pushed
the
1572-theming-charts
branch
from
ed0c47e to
fd9a477
Compare
mofojed
requested changes
Nov 3, 2023
Comment on lines
+21
to
+32
| static _theme: ChartTheme; | ||
|
|
||
| static get theme(): ChartTheme { | ||
| /* eslint-disable no-underscore-dangle */ | ||
| if (MockChartModel._theme == null) { | ||
| MockChartModel._theme = initChartTheme(); | ||
| } | ||
|
|
||
| return MockChartModel._theme; | ||
| /* eslint-enable no-underscore-dangle */ | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Shouldn't the theme be passed in to the constructor? As it is I don't see how this would update to if the user changes the theme in the Style Guide.
Contributor
Author
There was a problem hiding this comment.
This seems to only be used in static methods, so there's not really a constructor involved. I can probably just expose a setter that can be used by the Styleguide to change it, but I'll defer that until I implement the theme picker unless you have any objections.
bmingles
force-pushed
the
1572-theming-charts
branch
from
fd9a477 to
9a9bf88
Compare
- Colorway to single var - Renamed chart theme init deephaven#1572
bmingles
force-pushed
the
1572-theming-charts
branch
from
d1ece51 to
ff57e85
Compare
mofojed
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ChartThemeProvider, added support for resolving css variables in chart theme, and updated chart theme to use css variables.
resolves #1572
BREAKING CHANGE: