Skip to content

fix: Fixing grid colors and grays#1621

Merged
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:1572-fix-grid-colors
Nov 3, 2023
Merged

fix: Fixing grid colors and grays#1621
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:1572-fix-grid-colors

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Nov 3, 2023

  • Styleguide didn't have 850 actually mapped.
  • dh-gray-100 is mapped to content-bg but doesn't have a Bootstrap gray-xxx counterpart, so I added a Gray-8XX for illustration while we are still mapping things
  • Grid row was mapped to dh-gray-200 but should have been dh-gray-300
  • I added calculations for the hsl for grays instead of the all zero hue based ones I had before. They are still not exact but closer. I'm looking into fixing the rounding error.

#1572

@bmingles bmingles requested a review from dsmmcken November 3, 2023 16:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d4499b) 46.71% compared to head (8ba112e) 46.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   46.71%   46.71%           
=======================================
  Files         583      583           
  Lines       36308    36308           
  Branches     9094     9094           
=======================================
  Hits        16961    16961           
  Misses      19295    19295           
  Partials       52       52           
Flag Coverage Δ
unit 46.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/code-studio/src/styleguide/Colors.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--dh-color-grid-selection-outline-casing fix?

@bmingles bmingles requested a review from dsmmcken November 3, 2023 18:04
@bmingles bmingles merged commit 9ab2b1e into deephaven:main Nov 3, 2023
@bmingles bmingles deleted the 1572-fix-grid-colors branch November 3, 2023 20:05
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants