Skip to content

Theming - Inline svgs need to support dynamic css prop colors #1634

@bmingles

Description

@bmingles

We use inline svgs for certain icons. In some cases these are created via string concatenation with a Bootstrap color variable which is available at compile time. This does not work with dynamic CSS custom props which can change at runtime. We need to adjust this approach to support dynamic variables for theming.

  • Golden layout icons (e.g. .lm_maximise)
  • Form validation icons
  • Select input arrows

It should be possible to address some of these using svg masks, but others will likely require a .js based option to dynamically update svgs when themes change (should be able to store the svgs in css props and update them, but need to test this)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions