fix: Isolate Styleguide snapshots#1649
Merged
bmingles merged 3 commits intodeephaven:mainfrom Nov 17, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1649 +/- ##
=======================================
Coverage 46.65% 46.65%
=======================================
Files 593 593
Lines 36464 36467 +3
Branches 9133 9135 +2
=======================================
+ Hits 17012 17014 +2
- Misses 19400 19401 +1
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that snapshot tests for Styleguide were a bit brittle in that changes to a section in the Styleguide can cause subtle pixel shifts in snapshots of other sections. The snapshot tests now hide all sections not being tested to ensure they don't impact one another