feat: exposes editor-line-number-active-fg theme variable#1833
Merged
Conversation
Fixes issue with active line number looking bad in light theme. - Exposes editor-line-number-active-fg as editor semanatic variable - Sets to blue/black in light theme to match vs code light theme approach
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 628 628
Lines 37822 37826 +4
Branches 9529 9532 +3
=======================================
+ Hits 17440 17443 +3
- Misses 20328 20329 +1
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
approved these changes
Feb 26, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Confirmed line numbers + active line numbers look good in light + dark theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with active line number looking bad in light theme.