feat: Replaced RadioGroup with Spectrum's (#2020)#2021
Merged
bmingles merged 13 commits intodeephaven:mainfrom May 22, 2024
Merged
feat: Replaced RadioGroup with Spectrum's (#2020)#2021bmingles merged 13 commits intodeephaven:mainfrom
RadioGroup with Spectrum's (#2020)#2021bmingles merged 13 commits intodeephaven:mainfrom
Conversation
mofojed
requested changes
May 22, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Just want to clean up the example in the styleguide
mofojed
approved these changes
May 22, 2024
Comment on lines
+193
to
+195
| errorMessage={ | ||
| radioValue === '4' ? 'Invalid radio selected' : undefined | ||
| } |
Member
There was a problem hiding this comment.
Actually I don't think you necessarily need a ternary here, as the error message is only shown when it's invalid anyway. But no matter.
Suggested change
| errorMessage={ | |
| radioValue === '4' ? 'Invalid radio selected' : undefined | |
| } | |
| errorMessage="Invalid radio selected" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadioGroupandRadioItemcomponentsRadioGroupandRadiocomponentsHere's diffs of what the components look like after migrating to Spectrum RadioGroup:
FilterSetManager
ChartBuilder
TableCsvExporter
Aggregations
BREAKING CHANGE:
RadioGrouphas been replaced by SpectrumRadioGroup.RadioItemhas been replaced by SpectrumRadio