Skip to content

Required checks are not enforced properly for e2e #2044

@mattrunyon

Description

@mattrunyon

Our required build/e2e test seems to only be requiring the build step actually pass. This was probably broken when we changed to a matrix job as it used to be just 1 job instead of multiple jobs in a workflow.

Should be able to test by introducing a bad/failing e2e test. Notice how in these images the required test is passed, but there are later steps that failed.

We probably need to have the final step of merging the reports be the required check.

image
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions