fix: Reuse dashboard tabs when reassigning the variable#2243
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom Oct 2, 2024
Merged
fix: Reuse dashboard tabs when reassigning the variable#2243mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
dgodinez-dh
approved these changes
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
==========================================
+ Coverage 46.42% 46.44% +0.01%
==========================================
Files 698 698
Lines 38750 38736 -14
Branches 9885 9885
==========================================
- Hits 17990 17989 -1
+ Misses 20706 20693 -13
Partials 54 54 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1971
Tested with this code run 1 line at a time
Also tested dashboards still load in embed-widget. There was a race condition since the
makeUseListenerFunctionhook was usinguseEffect. This caused the event to emit between the event hub being set and the listener being added.