fix: Update react-spectrum packages#2303
Merged
mofojed merged 7 commits intodeephaven:mainfrom Nov 27, 2024
Merged
Conversation
- Fixes a bug with Meter not displaying it's variant correctly
e29223a to
5ceda8d
Compare
dgodinez-dh
previously approved these changes
Nov 26, 2024
- The way the classes were written was changed, snapshots needed to be updated
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
========================================
Coverage 46.60% 46.61%
========================================
Files 704 704
Lines 38963 38971 +8
Branches 9914 9733 -181
========================================
+ Hits 18158 18165 +7
- Misses 20794 20795 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- React spectrum updated the placeholder text from "Select an option..." to just "Select..."
bmingles
reviewed
Nov 27, 2024
bmingles
requested changes
Nov 27, 2024
Contributor
bmingles
left a comment
There was a problem hiding this comment.
Left 1 request to improve a TODO comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListDatanow allowingundefinedto be returned fromgetItem