Skip to content

fix: Update react-spectrum packages#2303

Merged
mofojed merged 7 commits intodeephaven:mainfrom
mofojed:update-react-spectrum
Nov 27, 2024
Merged

fix: Update react-spectrum packages#2303
mofojed merged 7 commits intodeephaven:mainfrom
mofojed:update-react-spectrum

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Nov 26, 2024

  • Fixes a bug with Meter not displaying it's variant correctly
  • Needed to resolve issue with ListData now allowing undefined to be returned from getItem
    • Just throw an error in this case, which should be the same behaviour as before

@mofojed mofojed requested a review from a team November 26, 2024 21:56
@mofojed mofojed self-assigned this Nov 26, 2024
@mofojed mofojed requested review from dgodinez-dh and removed request for a team November 26, 2024 21:56
- Fixes a bug with Meter not displaying it's variant correctly
@mofojed mofojed force-pushed the update-react-spectrum branch from e29223a to 5ceda8d Compare November 26, 2024 22:01
dgodinez-dh
dgodinez-dh previously approved these changes Nov 26, 2024
- The way the classes were written was changed, snapshots needed to be updated
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (5ebc195) to head (97a4d79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/react-hooks/src/SelectionUtils.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2303    +/-   ##
========================================
  Coverage   46.60%   46.61%            
========================================
  Files         704      704            
  Lines       38963    38971     +8     
  Branches     9914     9733   -181     
========================================
+ Hits        18158    18165     +7     
- Misses      20794    20795     +1     
  Partials       11       11            
Flag Coverage Δ
unit 46.61% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- React spectrum updated the placeholder text from "Select an option..." to just "Select..."
@mofojed mofojed requested a review from bmingles November 27, 2024 14:24
Comment thread packages/react-hooks/src/useMappedSelection.ts Outdated
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 request to improve a TODO comment.

@mofojed mofojed requested a review from bmingles November 27, 2024 16:24
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofojed mofojed merged commit 2216274 into deephaven:main Nov 27, 2024
@mofojed mofojed deleted the update-react-spectrum branch November 27, 2024 19:01
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants