feat: Add global shortcut to export logs#2336
Conversation
was moved into AppBootstrap.tsx
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
mofojed
left a comment
There was a problem hiding this comment.
I think the e2e test is failing in CI because the timeout may not be long enough - it may take a while for the UI to load in a resource constrained environment. You can increase the timeout for this call specifically by passing in the option: https://playwright.dev/docs/test-timeouts
…n-login-or-connection-fails
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
========================================
Coverage 46.70% 46.70%
========================================
Files 704 705 +1
Lines 39044 39051 +7
Branches 9757 9943 +186
========================================
+ Hits 18234 18240 +6
- Misses 20799 20800 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
was moved into AppBootstrap.tsx
mofojed
left a comment
There was a problem hiding this comment.
Looks great and resolves the ticket as specified! Going forward we can improve these error situations by having a visible button so the user doesn't need to remember a keyboard shortcut.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Ctrl+Alt+Shift+L/Cmd-Option-Shift-Las a global shortcut for exporting support logsCloses #1963