fix: Enable golden-layout jest test and fix broken EventUtils test#2467
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom Jun 24, 2025
Merged
fix: Enable golden-layout jest test and fix broken EventUtils test#2467mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
- Coverage 47.27% 44.64% -2.64%
==========================================
Files 727 755 +28
Lines 39767 42304 +2537
Branches 9949 10825 +876
==========================================
+ Hits 18800 18886 +86
- Misses 20956 23364 +2408
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed we had migrated a test into golden-layout, but it never ran. At a future point I then broke the test (not cleaning up event handlers on unmount), but it wasn't running so it wasn't caught.
This enables the test and fixes the broken logic so the test passes.