Skip to content

fix: Enable golden-layout jest test and fix broken EventUtils test#2467

Merged
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:golden-layout-jest
Jun 24, 2025
Merged

fix: Enable golden-layout jest test and fix broken EventUtils test#2467
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:golden-layout-jest

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

Noticed we had migrated a test into golden-layout, but it never ran. At a future point I then broke the test (not cleaning up event handlers on unmount), but it wasn't running so it wasn't caught.

This enables the test and fixes the broken logic so the test passes.

@mattrunyon mattrunyon requested a review from a team June 18, 2025 23:04
@mattrunyon mattrunyon self-assigned this Jun 18, 2025
@mattrunyon mattrunyon requested review from bmingles and removed request for a team June 18, 2025 23:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.64%. Comparing base (1c9a8ed) to head (2f3ca18).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
- Coverage   47.27%   44.64%   -2.64%     
==========================================
  Files         727      755      +28     
  Lines       39767    42304    +2537     
  Branches     9949    10825     +876     
==========================================
+ Hits        18800    18886      +86     
- Misses      20956    23364    +2408     
- Partials       11       54      +43     
Flag Coverage Δ
unit 44.64% <100.00%> (-2.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon merged commit 3e851f5 into deephaven:main Jun 24, 2025
10 of 11 checks passed
@mattrunyon mattrunyon deleted the golden-layout-jest branch June 24, 2025 15:39
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants