Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/golden-layout/jest.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const baseConfig = require('../../jest.config.base.cjs');
const packageJson = require('./package');

module.exports = {
...baseConfig,
displayName: packageJson.name,
};
10 changes: 9 additions & 1 deletion packages/golden-layout/src/utils/EventUtils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRef } from 'react';
import { useEffect, useRef } from 'react';
import EventEmitter from './EventEmitter';

type AsArray<P> = P extends unknown[] ? P : [P];
Expand Down Expand Up @@ -70,6 +70,14 @@ export function makeUseListenerFunction<TParameters = []>(

eventEmitterRef.current = eventEmitter;
handlerRef.current = handler;

// Cleanup on unmount
// Mounting the listener in useEffect causes a race condition with embed-widget
// where the event is emitted during render before the useEffect runs after render.
useEffect(
() => () => eventEmitterRef.current?.off(event, handlerRef.current),
[]
);
};
}

Expand Down
Loading