Skip to content

feat: DH-14431: Add shortcuts to cycle dashboards#2470

Merged
mofojed merged 2 commits intodeephaven:mainfrom
gzh2003:DH-14431-add-shortcuts-to-cycle-between-dashboards
Jun 24, 2025
Merged

feat: DH-14431: Add shortcuts to cycle dashboards#2470
mofojed merged 2 commits intodeephaven:mainfrom
gzh2003:DH-14431-add-shortcuts-to-cycle-between-dashboards

Conversation

@gzh2003
Copy link
Copy Markdown
Contributor

@gzh2003 gzh2003 commented Jun 23, 2025

Part of DH-14431. Introduces keyboard navigation shortcuts to cycle between dashboards.

Cmd/Ctrl + .: to cycle the active dashboard forward
Cmd/Ctrl + ,: to cycle the active dashboard backward

Changes:

  • Add shortcuts to cycle dashboard to NavigationShortcuts.ts
  • Registered the shortcuts as global context actions
  • Add handleCycleDashboardForward and handleCycleDashboardBackward to manage cycling

@gzh2003 gzh2003 requested a review from mofojed June 23, 2025 20:08
@gzh2003 gzh2003 self-assigned this Jun 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 47.25%. Comparing base (97098f2) to head (b13321c).

Files with missing lines Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
- Coverage   47.28%   47.25%   -0.03%     
==========================================
  Files         729      729              
  Lines       39919    39939      +20     
  Branches     9992     9997       +5     
==========================================
  Hits        18875    18875              
- Misses      21033    21053      +20     
  Partials       11       11              
Flag Coverage Δ
unit 47.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit 5b572c3 into deephaven:main Jun 24, 2025
16 of 18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2025
@gzh2003 gzh2003 deleted the DH-14431-add-shortcuts-to-cycle-between-dashboards branch June 25, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants