Skip to content

feat: DH-14431: Add shortcuts to cycle dashboards #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mofojed merged 2 commits into from
Jun 24, 2025
Merged

feat: DH-14431: Add shortcuts to cycle dashboards #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b13321c
Add shortcuts to cycle dashboards
gzh2003 Jun 23, 2025
14c241d
Revisions
gzh2003 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions packages/code-studio/src/main/AppMainContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ import {
} from '../settings/SettingsUtils';
import EmptyDashboard from './EmptyDashboard';

enum CycleDirection {
Next,
Previous,
}

const log = Log.module('AppMainContainer');

type InputFileFormat =
Expand Down Expand Up @@ -268,6 +273,20 @@ export class AppMainContainer extends Component<
shortcut: NAVIGATION_SHORTCUTS.CYCLE_TO_PREVIOUS_TAB,
isGlobal: true,
},
{
action: () => {
this.handleCycleDashboardForward();
},
shortcut: NAVIGATION_SHORTCUTS.CYCLE_TO_NEXT_DASHBOARD,
isGlobal: true,
},
{
action: () => {
this.handleCycleDashboardBackward();
},
shortcut: NAVIGATION_SHORTCUTS.CYCLE_TO_PREVIOUS_DASHBOARD,
isGlobal: true,
},
{
action: () => {
this.sendReopenLast();
Expand Down Expand Up @@ -464,6 +483,35 @@ export class AppMainContainer extends Component<
this.emitLayoutEvent(PanelEvent.REOPEN_LAST);
}

cycleDashboard(direction: CycleDirection): void {
const { tabs, activeTabKey } = this.state;

if (tabs.length <= 1) {
return;
}

const currentIndex = tabs.findIndex(tab => tab.key === activeTabKey);
if (currentIndex === -1) {
return;
}

const targetIndex =
direction === CycleDirection.Next
? (currentIndex + 1) % tabs.length
: (currentIndex - 1 + tabs.length) % tabs.length;

const targetTab = tabs[targetIndex];
this.handleTabSelect(targetTab.key);
}

handleCycleDashboardForward(): void {
this.cycleDashboard(CycleDirection.Next);
}

handleCycleDashboardBackward(): void {
this.cycleDashboard(CycleDirection.Previous);
}

getActiveEventHub(): EventHub {
const { activeTabKey } = this.state;
const layout = this.dashboardLayouts.get(activeTabKey);
Expand Down
14 changes: 14 additions & 0 deletions packages/components/src/shortcuts/NavigationShortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,20 @@ const NAVIGATION_SHORTCUTS = {
macShortcut: [MODIFIER.CMD, MODIFIER.SHIFT, KEY.SEMICOLON],
isEditable: true,
}),
CYCLE_TO_NEXT_DASHBOARD: ShortcutRegistry.createAndAdd({
id: 'NAVIGATION.CYCLE_TO_NEXT_DASHBOARD',
name: 'Cycle To Next Dashboard',
shortcut: [MODIFIER.CTRL, KEY.PERIOD],
macShortcut: [MODIFIER.CMD, KEY.PERIOD],
isEditable: true,
}),
CYCLE_TO_PREVIOUS_DASHBOARD: ShortcutRegistry.createAndAdd({
id: 'NAVIGATION.CYCLE_TO_PREVIOUS_DASHBOARD',
name: 'Cycle To Previous Dashboard',
shortcut: [MODIFIER.CTRL, KEY.COMMA],
macShortcut: [MODIFIER.CMD, KEY.COMMA],
isEditable: true,
}),
};

export default NAVIGATION_SHORTCUTS;
Loading
⚡