Skip to content

feat: DH-10205: Add column text alignment to web#2513

Merged
gzh2003 merged 12 commits intodeephaven:mainfrom
gzh2003:DH-10205-text-alignment-context-menu
Jul 31, 2025
Merged

feat: DH-10205: Add column text alignment to web#2513
gzh2003 merged 12 commits intodeephaven:mainfrom
gzh2003:DH-10205-text-alignment-context-menu

Conversation

@gzh2003
Copy link
Copy Markdown
Contributor

@gzh2003 gzh2003 commented Jul 29, 2025

For DH-10205. Allows users to override the default type-based alignment logic on a per column basis using a context menu.

Text alignment is determined with the following priority order: 1. context menu, 2.ui.table, 3. column type.

@gzh2003 gzh2003 requested a review from mofojed July 29, 2025 13:39
@gzh2003 gzh2003 self-assigned this Jul 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 33.84615% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.59%. Comparing base (d65ed40) to head (e3a8abd).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 15 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 16.66% 9 Missing and 1 partial ⚠️
packages/iris-grid/src/EmptyIrisGridModel.ts 0.00% 5 Missing ⚠️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 60.00% 4 Missing ⚠️
...at-context-menus/TextAlignmentFormatContextMenu.ts 42.85% 4 Missing ⚠️
...ode-studio/src/styleguide/MockIrisGridTreeModel.ts 0.00% 3 Missing ⚠️
packages/iris-grid/src/IrisGridProxyModel.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
- Coverage   44.67%   44.59%   -0.08%     
==========================================
  Files         762      764       +2     
  Lines       42618    42776     +158     
  Branches    10710    10960     +250     
==========================================
+ Hits        19038    19076      +38     
- Misses      23569    23641      +72     
- Partials       11       59      +48     
Flag Coverage Δ
unit 44.59% <33.84%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/iris-grid/src/IrisGridTableModelTemplate.ts Outdated
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor changes, looks great!

Comment thread packages/iris-grid/src/IrisGridModel.ts Outdated
Comment thread packages/iris-grid/src/format-context-menus/TextAlignmentFormatContextMenu.ts Outdated
Comment thread packages/iris-grid/src/mousehandlers/IrisGridContextMenuHandler.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
@gzh2003 gzh2003 requested review from mofojed and removed request for mofojed July 31, 2025 17:56
@gzh2003
Copy link
Copy Markdown
Contributor Author

gzh2003 commented Jul 31, 2025

Adding tests

@gzh2003 gzh2003 requested a review from mofojed July 31, 2025 18:51
@gzh2003 gzh2003 closed this Jul 31, 2025
@gzh2003 gzh2003 reopened this Jul 31, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2025
@gzh2003 gzh2003 merged commit 9cfa2c3 into deephaven:main Jul 31, 2025
20 of 21 checks passed
@gzh2003 gzh2003 deleted the DH-10205-text-alignment-context-menu branch July 31, 2025 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants