feat: DH-10205: Add column text alignment to web#2513
Merged
gzh2003 merged 12 commits intodeephaven:mainfrom Jul 31, 2025
Merged
feat: DH-10205: Add column text alignment to web#2513gzh2003 merged 12 commits intodeephaven:mainfrom
gzh2003 merged 12 commits intodeephaven:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
==========================================
- Coverage 44.67% 44.59% -0.08%
==========================================
Files 762 764 +2
Lines 42618 42776 +158
Branches 10710 10960 +250
==========================================
+ Hits 19038 19076 +38
- Misses 23569 23641 +72
- Partials 11 59 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gzh2003
commented
Jul 29, 2025
mofojed
requested changes
Jul 30, 2025
Member
mofojed
left a comment
There was a problem hiding this comment.
Couple minor changes, looks great!
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Contributor
Author
|
Adding tests |
mofojed
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DH-10205. Allows users to override the default type-based alignment logic on a per column basis using a context menu.
Text alignment is determined with the following priority order: 1. context menu, 2.ui.table, 3. column type.