Skip to content

feat: DH-19413: Expandable columns support#2537

Merged
mofojed merged 6 commits intodeephaven:mainfrom
vbabich:expandable-columns-main
Sep 19, 2025
Merged

feat: DH-19413: Expandable columns support#2537
mofojed merged 6 commits intodeephaven:mainfrom
vbabich:expandable-columns-main

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Sep 18, 2025

  • Add new ExpandableColumnGridModel interface for models with expandable columns
  • Export ColumnHeaderGroup and IrisGridCellRendererUtils from @deephaven/iris-grid
  • Add IrisGrid methods to expand/collapse columns
  • Update metrics on columns change in IrisGrid
  • IrisGridMetricCalculator now stores user column widths by name
  • parseColumnHeaderGroups in IrisGridUtils has an optional argument allowing to preserve the correct header group class
  • IrisGrid context menu shows Expand All and Collapse All if supported in the model
  • Update e2e snapshots, add unit tests

@vbabich vbabich self-assigned this Sep 18, 2025
@vbabich vbabich requested a review from mofojed September 18, 2025 13:29
@vbabich vbabich changed the title DH-13515: Expandable columns support feat: DH-13515: Expandable columns support Sep 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 71.55963% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.94%. Comparing base (ee2ba42) to head (026d442).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGrid.tsx 62.16% 14 Missing ⚠️
packages/iris-grid/src/IrisGridMetricCalculator.ts 74.50% 13 Missing ⚠️
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   44.56%   44.94%   +0.38%     
==========================================
  Files         764      765       +1     
  Lines       42821    42915      +94     
  Branches    10971    10793     -178     
==========================================
+ Hits        19084    19290     +206     
+ Misses      23726    23612     -114     
- Partials       11       13       +2     
Flag Coverage Δ
unit 44.94% <71.55%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. A few small things/suggestions.

Comment thread packages/iris-grid/src/IrisGrid.tsx
Comment thread packages/iris-grid/src/IrisGridMetricCalculator.ts Outdated
Comment thread packages/iris-grid/src/IrisGridMetricCalculator.ts Outdated
Comment thread packages/iris-grid/src/IrisGridMetricCalculator.ts
@mofojed mofojed merged commit 6938c47 into deephaven:main Sep 19, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2025
@vbabich vbabich changed the title feat: DH-13515: Expandable columns support feat: DH-19413: Expandable columns support Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants