feat: DH-19413: Expandable columns support#2537
Merged
mofojed merged 6 commits intodeephaven:mainfrom Sep 19, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 44.56% 44.94% +0.38%
==========================================
Files 764 765 +1
Lines 42821 42915 +94
Branches 10971 10793 -178
==========================================
+ Hits 19084 19290 +206
+ Misses 23726 23612 -114
- Partials 11 13 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7a10db3 to
2dc827a
Compare
mofojed
requested changes
Sep 18, 2025
Member
mofojed
left a comment
There was a problem hiding this comment.
Looking good overall. A few small things/suggestions.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpandableColumnGridModelinterface for models with expandable columnsColumnHeaderGroupandIrisGridCellRendererUtilsfrom@deephaven/iris-gridIrisGridmethods to expand/collapse columnsIrisGridIrisGridMetricCalculatornow stores user column widths by nameparseColumnHeaderGroupsinIrisGridUtilshas an optional argument allowing to preserve the correct header group classIrisGridcontext menu showsExpand AllandCollapse Allif supported in the model