fix(golden-layout): DH-22431: preserve focus indicator on nested dashboard tab#2664
Merged
mofojed merged 2 commits intodeephaven:mainfrom Apr 30, 2026
Merged
Conversation
Member
mofojed
commented
Apr 29, 2026
- When a dashboard is nested inside another dashboard, focusin events bubble from the inner content up to the outer container's contentElement. The outer Tab's focusin handler would clear the inner tab's lm_focusin class and claim focus for itself, leaving the active tab indicator in the wrong place.
- _onTabContentFocusIn now ignores events whose target lives inside a nested LayoutManager. _onTabClick treats focus inside a nested layout as 'not in this container' so clicking the outer tab properly transfers the indicator back out.
- Tested with the following deeply nested layout:
When a dashboard is nested inside another dashboard, focusin events bubble from the inner content up to the outer container's contentElement. The outer Tab's focusin handler would clear the inner tab's lm_focusin class and claim focus for itself, leaving the active tab indicator in the wrong place. _onTabContentFocusIn now ignores events whose target lives inside a nested LayoutManager. _onTabClick treats focus inside a nested layout as 'not in this container' so clicking the outer tab properly transfers the indicator back out.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
+ Coverage 49.75% 49.79% +0.04%
==========================================
Files 774 774
Lines 43881 43898 +17
Branches 11113 11308 +195
==========================================
+ Hits 21832 21860 +28
+ Misses 22031 21992 -39
- Partials 18 46 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsmmcken
approved these changes
Apr 29, 2026
Contributor
dsmmcken
left a comment
There was a problem hiding this comment.
Tested with example provided, confirmed working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.