fix: Conditional date formatting#1104
Merged
bmingles merged 3 commits intodeephaven:mainfrom Feb 27, 2023
Merged
Conversation
Util to validate date column conditions
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## main #1104 +/- ##
=======================================
Coverage 42.91% 42.92%
=======================================
Files 434 434
Lines 32597 32609 +12
Branches 8201 8209 +8
=======================================
+ Hits 13990 13997 +7
- Misses 18558 18563 +5
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
vbabich
requested changes
Feb 24, 2023
| return true; | ||
|
|
||
| default: | ||
| // TODO: we need to validate whether a given string can be parsed as a date |
Collaborator
There was a problem hiding this comment.
We usually avoid merging TODOs. Either fix the issue or file a ticket for it.
vbabich
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional formatting for date columns now properly prevents conditions with empty values from being applied.