fix: DH-12163 - Column grouping sidebar test failure fixes#1142
Merged
mattrunyon merged 4 commits intodeephaven:mainfrom Mar 8, 2023
Merged
fix: DH-12163 - Column grouping sidebar test failure fixes#1142mattrunyon merged 4 commits intodeephaven:mainfrom
mattrunyon merged 4 commits intodeephaven:mainfrom
Conversation
Collaborator
mattrunyon
commented
Mar 7, 2023
- Does not select new groups when searching
- Shows validation error if you create a new group and blur without typing anything into the name field
- Prevents Firefox on Mac from getting stuck in a bad state where color pickers can't be opened. The bug occurs when multiple color inputs are on the screen at once and the user clicks between the without closing the previous picker
Codecov Report
@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
+ Coverage 43.41% 43.43% +0.01%
==========================================
Files 435 435
Lines 32688 32701 +13
Branches 8244 8249 +5
==========================================
+ Hits 14193 14205 +12
- Misses 18446 18447 +1
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
reviewed
Mar 8, 2023
mofojed
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.