Skip to content

feat: Double click notebook tab to remove its preview status #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrunyon merged 2 commits into from
Mar 30, 2023
Merged

feat: Double click notebook tab to remove its preview status #1190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dc182
feat: Double click notebook tab to remove its preview status
mattrunyon Mar 30, 2023
a1d4f6a
Address review comment
mattrunyon Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/dashboard-core-plugins/src/panels/NotebookPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,9 +957,12 @@ class NotebookPanel extends Component<NotebookPanelProps, NotebookPanelState> {
});
}

handlePanelTabClick(): void {
handlePanelTabClick(e: MouseEvent): void {
Comment thread
mattrunyon marked this conversation as resolved.
Outdated
log.debug('handlePanelTabClick');
this.focus();
if (e.detail === 2) {
this.removePreviewStatus();
}
}

/**
Expand Down
7 changes: 3 additions & 4 deletions packages/golden-layout/src/controls/Tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ export default class Tab {
isComponent(this.contentItem)
) {
this.header.parent.setActiveContentItem(this.contentItem);
this.contentItem.container.emit('tabClicked');
} else if (
isComponent(this.contentItem) &&
!this.contentItem.container._contentElement[0].contains(
Expand All @@ -246,10 +245,10 @@ export default class Tab {
// if no focus inside put focus onto the container
// so focusin always fires for tabclicks
this.contentItem.container._contentElement.focus();
}

// still emit tab clicked event, so panels can also
// do it's own focus handling if desired
this.contentItem.container.emit('tabClicked');
if (isComponent(this.contentItem)) {
this.contentItem.container.emit('tabClicked', event);
}

// might have been called from the dropdown
Expand Down
⚡