feat(@deephaven/components): DH-14630 Custom React Spectrum Provider#1211
Merged
bmingles merged 13 commits intodeephaven:mainfrom Apr 18, 2023
Merged
feat(@deephaven/components): DH-14630 Custom React Spectrum Provider#1211bmingles merged 13 commits intodeephaven:mainfrom
bmingles merged 13 commits intodeephaven:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
+ Coverage 44.26% 45.05% +0.79%
==========================================
Files 450 451 +1
Lines 33480 33490 +10
Branches 8420 8427 +7
==========================================
+ Hits 14820 15090 +270
+ Misses 18610 18350 -260
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bmingles
force-pushed
the
1210-react-spectrum-provider
branch
from
57cef03 to
f2d0596
Compare
mofojed
reviewed
Apr 10, 2023
bmingles
force-pushed
the
1210-react-spectrum-provider
branch
from
d708121 to
aaa0b4d
Compare
bmingles
force-pushed
the
1210-react-spectrum-provider
branch
from
8d41a16 to
7da9471
Compare
mattrunyon
requested changes
Apr 12, 2023
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Update the breaking change to be 3rd person and specify which package needs to add react spectrum in the comment.
Can also do feat(@deephaven/components) in the title I believe to indicate the scope of the change
bmingles
changed the title
mofojed
previously approved these changes
Apr 14, 2023
mofojed
requested changes
Apr 17, 2023
mofojed
approved these changes
Apr 18, 2023
mattrunyon
approved these changes
Apr 18, 2023
bmingles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports Enterprise DH-14630
Custom React Spectrum Provider component.
resolves #1210