feat: De-globalize JSAPI in Console package#1292
Merged
vbabich merged 14 commits intodeephaven:mainfrom May 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 45.49% 45.50% +0.01%
==========================================
Files 504 504
Lines 34826 34828 +2
Branches 8688 8687 -1
==========================================
+ Hits 15844 15850 +6
+ Misses 18931 18927 -4
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
May 11, 2023
mofojed
requested changes
May 12, 2023
mofojed
requested changes
May 12, 2023
mofojed
previously approved these changes
May 12, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Looks good to me, think @mattrunyon may still want a look.
mofojed
reviewed
May 12, 2023
mofojed
reviewed
May 15, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Still reviewing the Enterprise side/functionality, so not approving yet. Only one minor cleanup comment.
mattrunyon
reviewed
May 15, 2023
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
One minor thing I saw. Looks fine to me though
mofojed
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dhreferences in the Console package, update consumers.SET_APIreducer.BREAKING CHANGE:
IrisGrid,Chart,ChartBuilder,AdvancedFilterCreator,GotoRow,IrisGridModelUpdater,TableCSVExporterget the JSAPI reference from themodelprop.dhprop removed.makeApiprops inIrisGridPanelandChartPanelremoved.Console,ConsoleMenu,ConsoleStatusBarnow require the JSAPI instance in thedhprop.ConsoleUtils: static methodsisTableType,isWidgetType,isOpenableType,isFigureType,isPandasrequire JSAPI instance passed in the first argument.SessionUtils: static methodscreateSessionWrapper,loadSessionWrapperrequire JSAPI instance passed in the first argument.IrisGridModelrequires JSAPI instance passed in the constructor args.DashboardLayout,ObjectIconhas to be wrapped inApiContext.Providerpassing the JSAPI instance.