feat: add uncaught rejections to support logs#1293
Merged
ethanalvizo merged 1 commit intodeephaven:mainfrom May 12, 2023
Merged
feat: add uncaught rejections to support logs#1293ethanalvizo merged 1 commit intodeephaven:mainfrom
ethanalvizo merged 1 commit intodeephaven:mainfrom
Conversation
ethanalvizo
force-pushed
the
1253-uncaught-promise-reject
branch
from
fa955df to
4a7c3d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
=======================================
Coverage 45.49% 45.49%
=======================================
Files 504 504
Lines 34826 34826
Branches 8688 8688
=======================================
Hits 15844 15844
Misses 18931 18931
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
mofojed
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1253