fix: makeApiContextWrapper and createMockProxy#1312
Merged
bmingles merged 6 commits intodeephaven:mainfrom May 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 492 493 +1
Lines 34374 34404 +30
Branches 8567 8580 +13
=======================================
+ Hits 15795 15811 +16
- Misses 18528 18542 +14
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vbabich
reviewed
May 23, 2023
| }: { | ||
| children?: ReactNode; | ||
| }, | ||
| _ref |
Collaborator
There was a problem hiding this comment.
I wonder what's the root cause of the issue? Why does renderHook require the ref? _ref argument isn't even passed anywhere, could this be a bug in renderHook itself?
Contributor
Author
There was a problem hiding this comment.
I suspect it uses it internally for something but not sure
Contributor
Author
There was a problem hiding this comment.
nvm, I was wrong. Real cause of the original issue is that ref needs to be excluded from the auto proxy
vbabich
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefinedin jest matchers. Proxied mock methods now include a mockName() call to give clearer outputfixes #1311