fix: truncated column headers#1319
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 493 493
Lines 34404 34404
Branches 8580 8580
=======================================
Hits 15811 15811
Misses 18542 18542
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
left a comment
There was a problem hiding this comment.
Just noting this class name needed to match the class name in BaseStyleSheet.scss. There is a comment in that file that is very outdated.
Not saying you need to change this, but if we wanted to be even more "foolproof", we wouldn't just be using class names that are defined in another package... maybe FontBootstrap instead of being passed in a bunch of class names, we'd pass in a bunch of styles to preload and then we'd just load some elements with those styles set (bypassing css/class names). That's out of scope for this patch though.
Closes #1318
Fixes bug in font pre-loading created in previous PR