Skip to content

fix: truncated column headers#1319

Merged
ethanalvizo merged 1 commit intodeephaven:mainfrom
ethanalvizo:1318-truncated-headers
May 24, 2023
Merged

fix: truncated column headers#1319
ethanalvizo merged 1 commit intodeephaven:mainfrom
ethanalvizo:1318-truncated-headers

Conversation

@ethanalvizo
Copy link
Copy Markdown
Contributor

Closes #1318

Fixes bug in font pre-loading created in previous PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2023

Codecov Report

Merging #1319 (cf561fb) into main (7bcf326) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files         493      493           
  Lines       34404    34404           
  Branches     8580     8580           
=======================================
  Hits        15811    15811           
  Misses      18542    18542           
  Partials       51       51           
Flag Coverage Δ
unit 45.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/app-utils/src/components/FontBootstrap.tsx 100.00% <100.00%> (ø)

@ethanalvizo ethanalvizo requested a review from mofojed May 24, 2023 19:29
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this class name needed to match the class name in BaseStyleSheet.scss. There is a comment in that file that is very outdated.

Not saying you need to change this, but if we wanted to be even more "foolproof", we wouldn't just be using class names that are defined in another package... maybe FontBootstrap instead of being passed in a bunch of class names, we'd pass in a bunch of styles to preload and then we'd just load some elements with those styles set (bypassing css/class names). That's out of scope for this patch though.

@ethanalvizo ethanalvizo merged commit db7716e into deephaven:main May 24, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncated Column Headers

2 participants