fix: Worker plugin definitions, optional panel wrapper for Dashboards#1329
Merged
mofojed merged 5 commits intodeephaven:mainfrom May 31, 2023
Merged
fix: Worker plugin definitions, optional panel wrapper for Dashboards#1329mofojed merged 5 commits intodeephaven:mainfrom
mofojed merged 5 commits intodeephaven:mainfrom
Conversation
Member
mofojed
commented
May 29, 2023
mofojed
commented
- Fix up some types for plugins
- Fix up some packaging
- Add an optional panel wrapper to Dashboard
- Allows consumer of Dashboard to pass in a wrapper component type that can wrap each panel - Will be handy for giving each panel different contexts for APIs
Codecov Report
@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 45.94% 45.94%
=======================================
Files 493 493
Lines 34410 34412 +2
Branches 8581 8582 +1
=======================================
+ Hits 15811 15812 +1
- Misses 18548 18549 +1
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
changed the title
vbabich
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.