fix: Cannot add control from Controls menu with click#1363
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jun 8, 2023
Merged
fix: Cannot add control from Controls menu with click#1363mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- We were defaulting the value to `null` instead of `undefined` - A golden-layout refactor explicitly checked for `undefined` instead of `null` - For some reason the type error in `FilterPlugin` and also `AppMainContainer` wasn't throwing an error when building?? Will need to investigate why not - Loosen restriction to just be `!= null` instead of `!== undefined` as that is the intent
Contributor
|
Is it the same event that is erroring if I look at GridPlugin.tsx? |
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 494 494
Lines 34423 34422 -1
Branches 8587 8586 -1
=======================================
Hits 15820 15820
+ Misses 18552 18551 -1
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dsmmcken
approved these changes
Jun 8, 2023
Contributor
dsmmcken
left a comment
dsmmcken
left a comment
There was a problem hiding this comment.
Works but event typing around this is messed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nullinstead ofundefinedundefinedinstead ofnullFilterPluginand alsoAppMainContainerwasn't throwing an error when building?? Will need to investigate why not!= nullinstead of!== undefinedas that is the intent